From: Alasdair G Kergon Date: Mon, 16 Mar 2009 19:10:23 +0000 Subject: [PATCH] pvcreate: conditionally wipe swap signatures In-Reply-To: <87tz5tl2jb.fsf@eriador.mornfall.net> References: <87tz5tl2jb.fsf@eriador.mornfall.net> Message-ID: <20090316191023.GE3063@agk.fab.redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Mar 16, 2009 at 07:56:40PM +0100, Peter Rockai wrote: > this should address https://bugzilla.redhat.com/show_bug.cgi?id=443062 -- the > first patch implements the actual check, in the spirit of dev_is_md (it also > gets a check in the testsuite). The code is based on swap signature detection > in swapon implementation of util-linux-ng: > http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=blob_plain;f=mount/swapon.c > The latter patch just throws in some checks that the old code misses. They > might as well be redundant (or not, depends on how you look at it). Personally, > I am ambivalent -- advice about (non-)inclusion sought. Ack to both patches. Alasdair -- agk at redhat.com