From: Wolfgang Denk Date: Wed, 18 Mar 2009 21:09:03 +0100 Subject: [U-Boot] [PATCH 1/8 v2] UBIFS: Implement read-only UBIFS support in U-Boot (Part 1) In-Reply-To: <1236866146-22095-1-git-send-email-sr@denx.de> References: <1236866146-22095-1-git-send-email-sr@denx.de> Message-ID: <20090318200903.F2788832E8B7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <1236866146-22095-1-git-send-email-sr@denx.de> you wrote: > --===============2128501430== > > This patchset adds UBIFS read-only support to U-Boot. The following > commands are implemented: > > - ubifsmount > Mount an UBIFS volume > > - ubifsls > List a directory of the mounted UBIFS volume > > - ubifsload > Load a file from the mounted UBIFS volume to memory > > The U-Boot UBIFS implementation is largely a direct copy from the current > Linux version (2.6.29-rc6). As already done in the UBI version we have an > "abstraction layer" to redefine or remove some OS calls (e.g. mutex_lock() > ...). This makes it possible to use the original Linux code with very > little changes. And by this we can better update to later Linux versions. > > I removed some of the Linux features that are not used in the U-Boot > version (e.g. garbage-collection, write support). > > Signed-off-by: Stefan Roese > CC: Artem Bityutskiy > CC: Adrian Hunter I don't understand the split of this patchset into 8 patches, which all use the very same subject (= commit title line) and commit message. It seems the splitting was done just for size reasons, not taking into account any logic parts that belong together or bi-sectability. Please explain why this is not just a single commit? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The face of war has never changed. Surely it is more logical to heal than to kill. -- Surak of Vulcan, "The Savage Curtain", stardate 5906.5