From: Mauro Carvalho Chehab Subject: Re: linux-next: Tree for March 19 (media/au8522) Date: Thu, 19 Mar 2009 21:06:33 -0300 Message-ID: <20090319210633.6911eba1@pedra.chehab.org> References: <20090319221024.5e2ad6e5.sfr@canb.auug.org.au> <49C27CC2.6070803@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49C27CC2.6070803@oracle.com> Sender: linux-media-owner@vger.kernel.org To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-media@vger.kernel.org, Devin Heitmueller List-Id: linux-next.vger.kernel.org On Thu, 19 Mar 2009 10:11:30 -0700 Randy Dunlap wrote: > Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20090318: > > > au8522_decoder.c:(.text+0x199898): undefined reference to `v4l2_ctrl_query_fill' > au8522_decoder.c:(.text+0x1998b3): undefined reference to `v4l2_ctrl_query_fill' > au8522_decoder.c:(.text+0x199944): undefined reference to `v4l2_device_unregister_subdev' > au8522_decoder.c:(.text+0x19997c): undefined reference to `v4l2_chip_ident_i2c_client' > au8522_decoder.c:(.text+0x199f1e): undefined reference to `v4l2_i2c_subdev_init' > Thanks! This were due to the fact that au8522 is now dependent on V4L2, since the same chip is used for both DVB frontand and Analog demodulation. Devin, IMO, you have a bad design here: You should try to have a core module with the common parts, and separate modules for the analog and the DVB parts of the chip. Anyway, for now, I just added the required dependencies at the Kconfig. Cheers, Mauro PS.: I'll be updating the linux-next patches later, after adding some other stuff. So, you'll probably see the fix for those reported issues merged only tomorrow.