From: Wolfgang Denk Date: Sun, 22 Mar 2009 15:21:01 +0100 Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() In-Reply-To: <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> References: <20090321133727.11905.38048.stgit@localhost> <20090321133844.11905.61201.stgit@localhost> <20090321194733.68507832E406@gemini.denx.de> <9e4733910903211339u60f5531cp7a9574f2d1ba264f@mail.gmail.com> <20090321205648.95B0F832E406@gemini.denx.de> <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> Message-ID: <20090322142101.DB34B832E406@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jon, In message <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> you wrote: > > I've test this version with the eeprom and it works correctly. It may work, but such a macro definition violates some rules. > +#define printf(format, arg...) if (gd->have_console) printf(format, ## arg) There are only a few places in cpu/mpc5xxx/i2c.c where printf() is used that we should explicitly code this, there. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Your own mileage may vary.