From: Wolfgang Denk Date: Sun, 22 Mar 2009 16:23:42 +0100 Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() In-Reply-To: <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> References: <20090321133727.11905.38048.stgit@localhost> <20090321133844.11905.61201.stgit@localhost> <20090321194733.68507832E406@gemini.denx.de> <9e4733910903211339u60f5531cp7a9574f2d1ba264f@mail.gmail.com> <20090321205648.95B0F832E406@gemini.denx.de> <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> <20090322142101.DB34B832E406@gemini.denx.de> <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> Message-ID: <20090322152342.26FD8832E406@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jon Smirl, In message <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> you wrote: > > Would it be better to put the check for (gd->have_console) into printf itself? No, as you could also use puts() or putc(). There are only a few isolated places where we need this, so let's make this clearly visible there. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The use of COBOL cripples the mind; its teaching should, therefore, be regarded as a criminal offence. -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5