From: Wolfgang Denk Date: Mon, 23 Mar 2009 07:24:23 +0100 Subject: [U-Boot] [PATCH 3/3] mpc5200: make i2c faster In-Reply-To: References: <20090321133727.11905.38048.stgit@localhost> <20090321133848.11905.59350.stgit@localhost> <20090322231651.GE20099@pengutronix.de> Message-ID: <20090323062423.7FE30832E406@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Grant Likely, In message you wrote: > > Even better, since this is entirely a busywait, the udelay(1) could be > dropped entirely and the exit condition be based on the value of > timebase. That would give the absolute maximum resolution to the > busyloop. However, the incremental improvement probably isn't a great > deal better than this patch. I disagree. Keep in mind that on systems with hardware watchdog enabled udelay() implicitly takes care of triggering the watchdog, so using it in busy-wait loops is always a good idea. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Build a system that even a fool can use and only a fool will want to use it.