From: Wolfgang Denk Date: Wed, 25 Mar 2009 22:51:53 +0100 Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() In-Reply-To: <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com> References: <20090321133727.11905.38048.stgit@localhost> <20090321133844.11905.61201.stgit@localhost> <20090321194733.68507832E406@gemini.denx.de> <9e4733910903211339u60f5531cp7a9574f2d1ba264f@mail.gmail.com> <20090321205648.95B0F832E406@gemini.denx.de> <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> <20090322142101.DB34B832E406@gemini.denx.de> <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> <20090322152342.26FD8832E406@gemini.denx.de> <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com> Message-ID: <20090325215153.12032832E406@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jon Smirl, In message <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com> you wrote: > On Sun, Mar 22, 2009 at 11:23 AM, Wolfgang Denk wrote: > > Dear Jon Smirl, > > > > In message <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> y= > ou wrote: > >> > >> Would it be better to put the check for (gd->have_console) =A0into print= > f itself? > > > > No, as you could also use puts() or putc(). =A0There =A0are =A0only =A0a = > =A0few > > isolated =A0places =A0where =A0we =A0need =A0this, =A0so =A0let's make th= > is clearly > > visible there. > > mpc5200 with eeprom, suppress printf until console initialized > > From: Jon Smirl Argh.... Such comments have to go *below* the '---' line, otherwise they become part of the commit message. And your patch is line-wrapped and thus corrupted by your mailer. Please FIX your mailer (or even better use git-send-email to submit patches). > On boards which have the environment in eeprom, i2c_init() > is called before the console and ram is initialized. Suppress > printfs until the console is initialized. > > Signed-off-by: Jon Smirl > --- > cpu/mpc5xxx/i2c.c | 30 ++++++++++++++++++++---------- > 1 files changed, 20 insertions(+), 10 deletions(-) Fixed manually and applied. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "In Christianity neither morality nor religion come into contact with reality at any point." - Friedrich Nietzsche