Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnhjI-0003gG-K7 for qemu-devel@nongnu.org; Sat, 28 Mar 2009 19:14:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnhjG-0003eF-Dc for qemu-devel@nongnu.org; Sat, 28 Mar 2009 19:14:19 -0400 Received: from [199.232.76.173] (port=36318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnhjG-0003e3-6X for qemu-devel@nongnu.org; Sat, 28 Mar 2009 19:14:18 -0400 Received: from hall.aurel32.net ([88.191.82.174]:57584) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LnhjF-0007YX-T7 for qemu-devel@nongnu.org; Sat, 28 Mar 2009 19:14:18 -0400 Received: from aurel32 by hall.aurel32.net with local (Exim 4.69) (envelope-from ) id 1LnhjE-0007qc-Di for qemu-devel@nongnu.org; Sun, 29 Mar 2009 00:14:16 +0100 Date: Sun, 29 Mar 2009 00:14:16 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 1/4] move PPC insn flags to cpu.h Message-ID: <20090328231416.GN20944@hall.aurel32.net> References: <1238275817-9758-1-git-send-email-froydnj@codesourcery.com> <1238275817-9758-2-git-send-email-froydnj@codesourcery.com> <20090328225805.GM20944@hall.aurel32.net> <20090328230751.GJ7336@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090328230751.GJ7336@codesourcery.com> Sender: Aurelien Jarno Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, Mar 28, 2009 at 04:07:52PM -0700, Nathan Froyd wrote: > On Sat, Mar 28, 2009 at 11:58:05PM +0100, Aurelien Jarno wrote: > > On Sat, Mar 28, 2009 at 02:30:14PM -0700, Nathan Froyd wrote: > > > It makes more sense to put the flags in the header file than in the > > > middle of translate.c. > > > > If those definition are not used outside of translate.c, it makes no > > sense to move them out to a header file included at multiple places. > > > > OTOH, I agree that having them in the middle of translate.c is a bit > > strange. Maybe we should move them at the top of the file along with > > other definitions? In that case, GEN_HANDLER* and EXTRACT_HELPER are > > also good candidates for the move. > > Whether they are placed at the top of translate.c or in cpu.h makes no > difference for this patch. I have an implementation of linux-user > signal handling for PPC32 that I'd like to submit soon, though. It > requires knowing what capabilities the CPU supports so it can figure out > what registers to save while setting up the signal frame. (Saving the > floating point registers makes no difference modulo speed, but the save > areas for the Altivec and SPE registers overlap.) So in the interest of > not having to move them twice, I'm lobbying for placing them in cpu.h. > I see. Then it's probably better to skip this patch in this patch series, and to add it in the series wrt linux-user changes. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net