From: Mike Frysinger Date: Sun, 29 Mar 2009 14:27:29 -0400 Subject: [U-Boot] [PATCH] SF: always read 5 bytes for the idcode In-Reply-To: <20090329144010.23734672@hskinnemoen-d830> References: <1238237002-7507-1-git-send-email-vapier@gentoo.org> <20090329144010.23734672@hskinnemoen-d830> Message-ID: <200903291427.30145.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 29 March 2009 08:40:10 Haavard Skinnemoen wrote: > Mike Frysinger wrote: > > Some SPI flash drivers like to have extended id information available > > (like the spansion flash), so rather than making it re-issue the ID cmd > > to get at the last 2 bytes, have the common code read 5 bytes rather than > > just 3. This also matches the Linux behavior where it always reads 5 id > > bytes from all flashes. > > > > Signed-off-by: Mike Frysinger > > CC: Mingkai Hu > > CC: Haavard Skinnemoen > > Yes, that's much better. But perhaps you should pass the last two bytes > to the debug() call a bit further down too? np, i'll update the patch for that -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090329/b8350d48/attachment-0001.pgp