From: Wolfgang Denk Date: Mon, 30 Mar 2009 09:45:32 +0200 Subject: [U-Boot] [PATCH] NetLoop initialization bug In-Reply-To: <49D054BA.1060904@denx.de> References: <660c0f820903221035hc791ba7t5e03e4e642991ce4@mail.gmail.com> <660c0f820903270059j5642e0dw62489939e4385326@mail.gmail.com> <49D054BA.1060904@denx.de> Message-ID: <20090330074532.85DFE83797DC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko, In message <49D054BA.1060904@denx.de> you wrote: > > The following 2 vars are just used, if CONFIG_CMD_CDP > is used, can we do a "#if defined" around it? > > + NetOurNativeVLAN = getenv_VLAN("nvlan"); > > + NetOurVLAN = getenv_VLAN("vlan"); We probably could, but we then had to do this in several places, and the code would become less readable, I think. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Q: How many DEC repairman does it take to fix a flat ? A: Five; four to hold the car up and one to swap tires.