From: Nick Piggin Subject: [patch] fs: add a remount,ro coherency point Date: Mon, 30 Mar 2009 13:33:54 +0200 Message-ID: <20090330113354.GC31000@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Jorge Boncompte [DTI2]" , linux-fsdevel@vger.kernel.org, Andrew Morton To: viro@zeniv.linux.org.uk Return-path: Received: from cantor.suse.de ([195.135.220.2]:43396 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757601AbZC3Ld6 (ORCPT ); Mon, 30 Mar 2009 07:33:58 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: fs: invalidate sb->s_bdev on remount,ro Fixes a problem reported by "Jorge Boncompte [DTI2]" who is trying to snapshot a minix filesystem image. Signed-off-by: Nick Piggin --- fs/super.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-2.6/fs/super.c =================================================================== --- linux-2.6.orig/fs/super.c +++ linux-2.6/fs/super.c @@ -647,6 +647,14 @@ int do_remount_sb(struct super_block *sb acct_auto_close(sb); shrink_dcache_sb(sb); fsync_super(sb); + /* Some filesystems modify their metadata via some other path + than the bdev buffer cache (eg. use a private mapping, or + directories in pagecache, etc). Also file data modifications + go via their own mappings. So If we try to mount readonly + then copy the filesystem from bdev, we could get stale data, + so invalidate it to give a best effort at coherency. */ + if (flags & MS_RDONLY && sb->s_bdev) + invalidate_bdev(sb->s_bdev); /* If we are remounting RDONLY and current sb is read/write, make sure there are no rw files opened */