From: Wolfgang Denk Date: Tue, 31 Mar 2009 22:36:23 +0200 Subject: [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb In-Reply-To: <3efb10970903311128t2b9ac2dn4d4b1ee9022a855b@mail.gmail.com> References: <1238193026-12564-1-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-2-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-3-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-4-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-5-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-6-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-7-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-8-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-9-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-10-git-send-email-plagnioj@jcrosoft.com> <3efb10970903311128t2b9ac2dn4d4b1ee9022a855b@mail.gmail.com> Message-ID: <20090331203623.552DC83797DC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Remy Bohmer, In message <3efb10970903311128t2b9ac2dn4d4b1ee9022a855b@mail.gmail.com> you wrote: > > > ?drivers/usb/Makefile ? ? ? ? ? ? ? ? ? ? ? ? > ? ? ? | ? ?1 + > > ?.../at91/usb.c => drivers/usb/atmel_usb.c ? ? ? ? ?| ? > ?0 > > ?rename cpu/arm926ejs/at91/usb.c => drivers/usb/atmel_usb.c (100%) > > Same here, this is architecture specific code, why move it to generic code? I agree with Remy here. The modification makes no sense to me. Please don't. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "One day," said a dull voice from down below, "I'm going to be back in form again and you're going to be very sorry you said that. For a very long time. I might even go so far as to make even more Time just for you to be sorry in." - Terry Pratchett, _Small Gods_