Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lom8j-0006tY-8u for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:09:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lom8e-0006sa-KW for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:09:00 -0400 Received: from [199.232.76.173] (port=42363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lom8e-0006sV-Gf for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:08:56 -0400 Received: from mx20.gnu.org ([199.232.41.8]:39228) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lom8e-0004gR-8M for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:08:56 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lom8d-0001U7-C0 for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:08:55 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 05/17] Fix and cleanup IPCOP_shm* ipc calls handling Date: Tue, 31 Mar 2009 22:08:52 +0000 References: <0007b0851a779060f010f33e9f5c79d818ce9d21.1238531009.git.riku.voipio@iki.fi> In-Reply-To: <0007b0851a779060f010f33e9f5c79d818ce9d21.1238531009.git.riku.voipio@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200903312308.53162.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi On Tuesday 31 March 2009, riku.voipio@iki.fi wrote: > + =A0 =A0*raddr =3D (unsigned long) shmat(shmid, g2h(shmaddr), shmflg); This is wrong. You need to handle NULL properly. Paul