Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LozEL-0004eV-Ut for qemu-devel@nongnu.org; Wed, 01 Apr 2009 08:07:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LozEJ-0004eJ-FV for qemu-devel@nongnu.org; Wed, 01 Apr 2009 08:07:40 -0400 Received: from [199.232.76.173] (port=34785 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LozEI-0004eD-OL for qemu-devel@nongnu.org; Wed, 01 Apr 2009 08:07:39 -0400 Received: from hall.aurel32.net ([88.191.82.174]:35649) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LozEI-0008NL-9k for qemu-devel@nongnu.org; Wed, 01 Apr 2009 08:07:38 -0400 Date: Wed, 1 Apr 2009 14:07:30 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 00/17] linux-user patches in maemo Message-ID: <20090401120730.GX12026@hall.aurel32.net> References: <200903312331.43023.paul@codesourcery.com> <20090401093117.GA16793@kos.to> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090401093117.GA16793@kos.to> Sender: Aurelien Jarno Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paul Brook On Wed, Apr 01, 2009 at 12:31:17PM +0300, Riku Voipio wrote: > On Tue, Mar 31, 2009 at 10:31:42PM +0000, Paul Brook wrote: > > > This some of the more cleaner linux-user patches maemo version > > > of qemu carries. The idea was to setup a "linux-user-for-upstream" > > > branch to git.maemo.org, but unfortunately the server is refusink > > > my git pushes ATM. > > > These patches don't seem particularly coherent. > > Some of them actually depend on preceding patches, others implement completely > > independent features. > > No problem, I can split these to smaller series. > > > In some places you modify code, only to change that code again in a later > > patch. For example patch #7 appears to be purely a fix for bugs introduced by > > patch #5 > > These specific patches are unmodified patches submitted by Kirill in October > last year, without anyone complaining.. I'll squash patches together where > newer ones changes code of older patches. > The one from October are actually a resent of an earlier series. I haven't look at the one you selected, but from what I remember they have a lot of unrelated indentation change, making them difficult to review. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net