From: Wolfgang Denk Date: Thu, 02 Apr 2009 00:14:38 +0200 Subject: [U-Boot] [PATCH 07/13] at91rm9200: move serial driver to drivers/serial In-Reply-To: <1238193026-12564-7-git-send-email-plagnioj@jcrosoft.com> References: <1238193026-12564-1-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-2-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-3-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-4-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-5-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-6-git-send-email-plagnioj@jcrosoft.com> <1238193026-12564-7-git-send-email-plagnioj@jcrosoft.com> Message-ID: <20090401221438.2610683797DC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1238193026-12564-7-git-send-email-plagnioj@jcrosoft.com> you wrote: > add CONFIG_AT91RM9200_USART to activate the driver > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > cpu/arm920t/at91rm9200/Makefile | 2 +- > drivers/serial/Makefile | 1 + > .../serial.c => drivers/serial/at91rm9200_usart.c | 0 > include/configs/at91rm9200dk.h | 1 + > include/configs/at91rm9200ek.h | 1 + > include/configs/cmc_pu2.h | 1 + > include/configs/csb637.h | 1 + > include/configs/kb9202.h | 1 + > include/configs/m501sk.h | 1 + > include/configs/mp2usb.h | 1 + > 10 files changed, 9 insertions(+), 1 deletions(-) > rename cpu/arm920t/at91rm9200/serial.c => drivers/serial/at91rm9200_usart.c (100%) What the heck is this? A new version of the previously submitted patch? Why do you not mark this in the subject line like "[PATCH 07/13 V2]" or similar? Why do you not add any comment? It is IMPOSSIBLE this way to keep track of which patch versions might be current in your patch stack. This is a nightmare. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Motto of the Electrical Engineer: Working computer hardware is a lot like an erect penis: it stays up as long as you don't fuck with it.