From: Jean-Christophe PLAGNIOL-VILLARD Date: Thu, 2 Apr 2009 15:26:32 +0200 Subject: [U-Boot] [PATCH 5/8] ZOOM2 Add led support. In-Reply-To: <49D4BFE3.7050907@windriver.com> References: <1238641341-26714-1-git-send-email-Tom.Rix@windriver.com> <1238641341-26714-2-git-send-email-Tom.Rix@windriver.com> <1238641341-26714-3-git-send-email-Tom.Rix@windriver.com> <1238641341-26714-4-git-send-email-Tom.Rix@windriver.com> <1238641341-26714-5-git-send-email-Tom.Rix@windriver.com> <20090402053004.GJ14366@game.jcrosoft.org> <49D4BFE3.7050907@windriver.com> Message-ID: <20090402132632.GF2651@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08:38 Thu 02 Apr , Tom wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: >> why not using the arm led API?? >> > OK. I will fix. >>> +{ >>> + gpio_t *gpio6_base = (gpio_t *) OMAP34XX_GPIO6_BASE; >>> + >>> + sr32 (&gpio6_base->cleardataout, 13, 1, 1); /* red off */ >>> >> we clearly need now a GPIO API it's start to be mandatory >> >> > Like what is in the kernel or something similar? as you wish but share the same API for the omap3 on u-boot and the kernel will be nice. We do it for example on at91 or avr32 Best Regards, J.