From: Nick Piggin Subject: Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46] Date: Fri, 3 Apr 2009 01:00:04 +1100 Message-ID: <200904030100.05741.nickpiggin@yahoo.com.au> References: <20090401230321.28177.12010.stgit@warthog.procyon.org.uk> <20090401230515.28177.73948.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1324275403==" Cc: linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org To: David Howells Return-path: In-Reply-To: <20090401230515.28177.73948.stgit@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org --===============1324275403== Content-Type: multipart/alternative; boundary="Boundary-00=_lTM1JfcCpA04svh" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-00=_lTM1JfcCpA04svh Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Thursday 02 April 2009 10:05:15 David Howells wrote: > Add an address space operation to write one single page of data to an inode > at a page-aligned location (thus permitting the implementation to be highly > optimised). The data source is a single page. > > This is used by CacheFiles to store the contents of netfs pages into their > backing file pages. > > Supply a generic implementation for this that uses the write_begin() and > write_end() address_space operations to bind a copy directly into the page > cache. > > Hook the Ext2 and Ext3 operations to the generic implementation. Is this really worthwhile? What do you do that write_begin/write_end doesn't? I have a patch around somewhere enable splice stealing into the pagecache with write_begin/write_end if you are worried about the copy. But how about you put this at the end of the series justified with some numbers? --Boundary-00=_lTM1JfcCpA04svh Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

On Thursday 02 April 2009 10:05:15 David Howells wrote:

> Add an address space operation to write one single page of data to an inode

> at a page-aligned location (thus permitting the implementation to be highly

> optimised). The data source is a single page.

>

> This is used by CacheFiles to store the contents of netfs pages into their

> backing file pages.

>

> Supply a generic implementation for this that uses the write_begin() and

> write_end() address_space operations to bind a copy directly into the page

> cache.

>

> Hook the Ext2 and Ext3 operations to the generic implementation.

Is this really worthwhile? What do you do that write_begin/write_end

doesn't? I have a patch around somewhere enable splice stealing into

the pagecache with write_begin/write_end if you are worried about the

copy. But how about you put this at the end of the series justified

with some numbers?

--Boundary-00=_lTM1JfcCpA04svh-- --===============1324275403== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ NFSv4 mailing list NFSv4@linux-nfs.org http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4 --===============1324275403==--