From: Nick Piggin Subject: Re: [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management [ver #46] Date: Fri, 3 Apr 2009 04:31:03 +1100 Message-ID: <200904030431.04079.nickpiggin@yahoo.com.au> References: <200904030353.17713.nickpiggin@yahoo.com.au> <200904030315.03606.nickpiggin@yahoo.com.au> <7249.1238692155@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org To: David Howells Return-path: In-Reply-To: <7249.1238692155@redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org On Friday 03 April 2009 04:09:15 David Howells wrote: > Nick Piggin wrote: > > > Comments about PG_private still stand. > > Replies about PG_private still stand. > > It's owned by fs/buffer.c, and if the 'netfs' uses that, then PG_private is > not available. Well in theory I still think it would be cleanest to modify buffer to play more nicely with it. But maybe that ends up being harder to distinguish the 3 cases of attached metadata on the page. I don't know, you haven't posted any isofs code so either way it is inappropriate to use up this extra page flag here. Is isofs cache worth a page flag?