From: Wolfgang Denk Date: Fri, 03 Apr 2009 23:57:28 +0200 Subject: [U-Boot] [PATCH v2] netloop: updates for NetLoop In-Reply-To: <49A641E4.8000001@denx.de> References: <49A53C4D.5060907@denx.de> <200902251201.45611.vapier@gentoo.org> <49A641E4.8000001@denx.de> Message-ID: <20090403215728.930BE83797DC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ben, In message <49A641E4.8000001@denx.de> you wrote: > [PATCH v2] netloop: updates for NetLoop > > Fix some issues introduced from commit: > 2f70c49e5b9813635ad73666aa30f304c7fdeda9 > suggested by Mike Frysinger. > > - added some comment for the env_id variable in common_cmd_nvedit.c > - moved some variables in fn scope instead of file scope > - NetInitLoop now static void > > Signed-off-by: Heiko Schocher > --- > changes since v1: > - added comments from Mike Frysinger > > common/cmd_nvedit.c | 7 +++++++ > net/eth.c | 5 ++--- > net/net.c | 8 +++----- > 3 files changed, 12 insertions(+), 8 deletions(-) Except for an Ack from Mike I did not see any comments? Ditto for this one: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55341 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Children are natural mimics who act like their parents despite every effort to teach them good manners.