Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LqTe1-0001aY-8M for mharc-grub-devel@gnu.org; Sun, 05 Apr 2009 10:48:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqTdy-0001a1-Un for grub-devel@gnu.org; Sun, 05 Apr 2009 10:48:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqTdy-0001Zc-GA for grub-devel@gnu.org; Sun, 05 Apr 2009 10:48:18 -0400 Received: from [199.232.76.173] (port=52487 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqTdy-0001ZY-Bz for grub-devel@gnu.org; Sun, 05 Apr 2009 10:48:18 -0400 Received: from mail.nexedi.com ([91.121.25.85]:39784 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LqTdx-0002Oc-Up for grub-devel@gnu.org; Sun, 05 Apr 2009 10:48:18 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 6B0193D9F2 for ; Sun, 5 Apr 2009 16:48:15 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sun, 5 Apr 2009 23:48:15 +0900 User-Agent: KMail/1.9.10 References: <49AEEF72.5050000@gmail.com> <49C3EF85.5080908@gmail.com> <49D726DF.4010601@gmail.com> In-Reply-To: <49D726DF.4010601@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904052348.15540.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] parttool X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2009 14:48:19 -0000 On Saturday 04 April 2009 18:22:39 phcoder wrote: > Can someone review this patch? Only some style should be corrected. For example: +#ifndef GRUB_UTIL + if (!parts) + grub_dl_unref (mymod); +#endif Our convention is to put a space between "!" and "parts", so this should be: +#ifndef GRUB_UTIL + if (! parts) + grub_dl_unref (mymod); +#endif Also, the ChangeLog should state what variables are affected explicitly. For example: * conf/common.rmk: Added parttool.mod and pcpart.mod Instead, you should say: * conf/common.rmk (parttool_mod_SOURCES): New variable. (parttool_mod_CFLAGS): Likewise. (parttool_mod_LDFLAGS): Likewise. ...and so on... The code itself looks good, so you can check it in, once you correct the styles. Regards, Okuji