From: Jeff Layton Subject: Re: [PATCH 3/5] nfs-utils: query for remote port using rpcbind instead of getaddrinfo Date: Tue, 7 Apr 2009 19:27:29 -0400 Message-ID: <20090407192729.3fc55cb5@tleilax.poochiereds.net> References: <1239117946-7535-1-git-send-email-jlayton@redhat.com> <1239117946-7535-4-git-send-email-jlayton@redhat.com> <41F98279-F000-4C1C-8E44-3568C89FC2BD@oracle.com> <49db7f0d.85c2f10a.5025.ffffb257@mx.google.com> <20090407131151.69203e5e@tleilax.poochiereds.net> <49dbacf3.14025a0a.5898.ffffbaa2@mx.google.com> <20090407155305.5790407c@tleilax.poochiereds.net> <49dbb129.02045a0a.023b.6bc7@mx.google.com> <20090407163019.4eae5367@tleilax.poochiereds.net> <20090407231606.GD28733@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20090407231606.GD28733@fieldses.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-ID: On Tue, 7 Apr 2009 19:16:06 -0400 "J. Bruce Fields" wrote: > On Tue, Apr 07, 2009 at 04:30:19PM -0400, Jeff Layton wrote: > > On Tue, 07 Apr 2009 16:01:31 -0400 > > Tom Talpey wrote: > > > > > > > > > > >I'd rather see these people just update their kernels so that this > > > >isn't needed... > > > > > > Agreed. Would it make sense to log a message when the default 2049 > > > is used? At least then, there's a chance an admin will know it's needed. > > > > > > > That's sounds reasonable. I've already asked Steve to commit the latest > > set, but we should be able to add something like this untested patch on > > top of it. > > > > If it looks ok, I'll test it out and officially resend it... > > > > Thoughts? > > Would it work to do this in mount?--do the mount, then check any new > info file in rpc_pipefs to see if there's a port field? > > Then we could give the error to the user where it's actually useful (as > output from the mount command). And also maybe only bother with it when > port= was specified. > > --b. > It's not really an error per-se. Given that 99%+ NFS connections are done on standard ports, I consider this to just be a helpful warning that might point someone in the right direction when this does occur. Adding code to mount for this seems like overkill, IMO... -- Jeff Layton