Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lsf9r-0001Gw-KT for mharc-grub-devel@gnu.org; Sat, 11 Apr 2009 11:30:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lsf9p-0001GU-K1 for grub-devel@gnu.org; Sat, 11 Apr 2009 11:30:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lsf9k-0001GD-B2 for grub-devel@gnu.org; Sat, 11 Apr 2009 11:30:12 -0400 Received: from [199.232.76.173] (port=53332 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lsf9k-0001GA-7w for grub-devel@gnu.org; Sat, 11 Apr 2009 11:30:08 -0400 Received: from gateway11.websitewelcome.com ([67.18.70.3]:43001) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Lsf9j-0002xu-NP for grub-devel@gnu.org; Sat, 11 Apr 2009 11:30:08 -0400 Received: (qmail 17549 invoked from network); 11 Apr 2009 15:32:04 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway11.websitewelcome.com with SMTP; 11 Apr 2009 15:32:04 -0000 Received: from [67.185.177.95] (port=34113 helo=svelte.localnet) by gator297.hostgator.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1Lsf9g-0000a7-O6; Sat, 11 Apr 2009 10:30:04 -0500 From: Colin D Bennett To: grub-devel@gnu.org Date: Sat, 11 Apr 2009 08:29:59 -0700 User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; x86_64; ; ) References: <1232851143.23773.13.camel@localhost> <49DFD57E.9040905@gmail.com> <200904111909.48927.okuji@enbug.org> In-Reply-To: <200904111909.48927.okuji@enbug.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2218265.i3egvf2zj2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200904110830.02945.colin@gibibit.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: "Yoshinori K. Okuji" Subject: Re: [PATCH] Build system improvement X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 15:30:13 -0000 --nextPart2218265.i3egvf2zj2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Yoshinori K. Okuji wrote on Saturday 11 April 2009: > On Saturday 11 April 2009 08:25:50 phcoder wrote: > > I don't see any stoppers to merge this patch > > Personally, I don't like this so much. Is it so useful? Absolutely. I find it tedious to scroll back through thousands of lines of= =20 text full of gcc command lines with lots of options etc. to find the actual= =20 warnings that could indicate (and usually do!) that I made an error in my=20 code. When all the lines generally have a concise and uniform appearance, = it=20 is visually easy to scan for warnings, compared to now where the lines prin= ted=20 are very long and often wrap onto multiple lines, obscuring warnings. If we could build with -Werror, then it wouldn't be so hard to find the=20 warnings since the build would abort... I think there is only one warning (the =E2=80=9Ctrampoline=E2=80=9D warning= ) that we want to=20 ignore. All others can and should be fixed (and they may be already). Regards, Colin > > Javier Mart=C3=ADn wrote: > > > This patch modifies several files in the build system (mainly > > > common.rmk and genmk.rb) to reduce the general verbosity of the build > > > process to a manageable, semi-informative level. Thus, what currently > > > appears as "gcc" calls, several lines long each is turned into lines > > > like: > > > > > > [M xfs.mod] COMPILE ../src/fs/xfs.c -> > > > xfs_mod-fs_xfs.o > > > [M xfs.mod] LINK xfs_mod-fs_xfs.o -> > > > pre-xfs.o > > > [M xfs.mod] Looking for EXPORTED SYMBOL definitions: pre-xfs.o > > > > > > And so on. The change also makes warning-hunting marginally easier, > > > though not by much since the patch intentionally shows a line for > > > nearly every process that did so previously. This behavior could be > > > simplified further if needed - this post is more of an RFC than > > > anything else. Also, it is by no means thorough or complete - only the > > > most common processes have been addressed - as I'm a bit busy with > > > exams. > > > > > > The patch makes the new behavior the default one, so a new make-time > > > option is added: V (for "verbose"), which must have the value 1 in > > > order to get the behavior, as in "make V=3D1" --nextPart2218265.i3egvf2zj2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkngt3gACgkQokx8fzcGbYfT4gCeP3K9yOXGcyUi6qsIwRis4KUK ZlUAnjOMRCtege2x0BtGFVQwrMRhFVnu =9gE9 -----END PGP SIGNATURE----- --nextPart2218265.i3egvf2zj2--