Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lt0XU-00081O-M4 for mharc-grub-devel@gnu.org; Sun, 12 Apr 2009 10:20:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lt0XS-00080i-Re for grub-devel@gnu.org; Sun, 12 Apr 2009 10:20:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lt0XN-00080O-NH for grub-devel@gnu.org; Sun, 12 Apr 2009 10:20:01 -0400 Received: from [199.232.76.173] (port=33985 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lt0XN-00080L-Ik for grub-devel@gnu.org; Sun, 12 Apr 2009 10:19:57 -0400 Received: from arnold.marlboro.edu ([206.192.68.78]:37967) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lt0XN-0002Dp-7p for grub-devel@gnu.org; Sun, 12 Apr 2009 10:19:57 -0400 Received: from akbar.marlboro.edu (akbar.marlboro.edu [10.1.2.5]) by arnold.marlboro.edu (Postfix) with ESMTP id 63F14178064; Sun, 12 Apr 2009 10:19:23 -0400 (EDT) Received: from xyz.marlboro.edu (xyz.marlboro.edu [10.1.2.29]) by akbar.marlboro.edu (Postfix) with ESMTP id 5F46911E55D; Sun, 12 Apr 2009 10:19:23 -0400 (EDT) Received: from east.localnet (mdhcp171.marlboro.edu [10.1.4.171]) by xyz.marlboro.edu (Postfix) with ESMTP id EAE973AC0C9; Sun, 12 Apr 2009 10:19:19 -0400 (EDT) From: Isaac Dupree To: grub-devel@gnu.org Date: Sun, 12 Apr 2009 10:19:18 -0400 User-Agent: KMail/1.10.4 (Linux/2.6.27-11-generic; KDE/4.1.4; x86_64; ; ) References: <200904111919.49761.okuji@enbug.org> <20090412.010719.229891360.davem@davemloft.net> <49E1E2BC.3020405@gmail.com> In-Reply-To: <49E1E2BC.3020405@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904121019.18535.ml@isaac.cedarswampstudios.org> X-Marlboro-MailScanner-Information: Please contact techsupport@marlboro.edu for more information X-Marlboro-MailScanner: Found to be clean, clean X-Marlboro-Information: Please contact techsupport@marlboro.edu for more information X-Marlboro-MailScanner-ID: 63F14178064.1EA3B X-Marlboro-SpamCheck: not spam (whitelisted), SpamAssassin (not cached, score=-4.399, required 6, autolearn=disabled, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-Marlboro-MailScanner-From: ml@isaac.cedarswampstudios.org X-Marlboro-MailScanner-Watermark: 1240150763.86501@6+5nEdNRdbpX+kJKrIFHWA X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: phcoder , David Miller Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 14:20:03 -0000 > - grub_ltoa (tmp, c, l); > + grub_lltoa (tmp, c, l); > } > else > { > n = va_arg (args, int); > - grub_itoa (tmp, c, n); > + grub_lltoa (tmp, c, n); Do you think they deserve a comment saying why lltoa and that e.g. grub_ltoa would work equally well there except for space reasons? (In case we ever decided to change that code back, it would be easier to figure out.) -Isaac