Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LtMhT-000064-EK for mharc-grub-devel@gnu.org; Mon, 13 Apr 2009 09:59:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtMhQ-00005k-CK for grub-devel@gnu.org; Mon, 13 Apr 2009 09:59:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtMhL-000054-8Q for grub-devel@gnu.org; Mon, 13 Apr 2009 09:59:47 -0400 Received: from [199.232.76.173] (port=49640 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtMhK-00004z-VB for grub-devel@gnu.org; Mon, 13 Apr 2009 09:59:43 -0400 Received: from aybabtu.com ([69.60.117.155]:43712) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LtMhK-00085n-GN for grub-devel@gnu.org; Mon, 13 Apr 2009 09:59:42 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LtMVt-0002Fj-Is for grub-devel@gnu.org; Mon, 13 Apr 2009 15:47:54 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LtMhH-0003Ao-L9 for grub-devel@gnu.org; Mon, 13 Apr 2009 15:59:39 +0200 Date: Mon, 13 Apr 2009 15:59:39 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090413135939.GC12170@thorin> References: <20090304163509.GA26106@riva.ucam.org> <20090304211629.GJ31201@thorin> <20090304212356.GL31201@thorin> <49DFD0AF.2070803@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49DFD0AF.2070803@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Support up to 256 SCSI disks on Linux X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 13:59:48 -0000 On Sat, Apr 11, 2009 at 01:05:19AM +0200, phcoder wrote: > Robert Millan wrote: >> On Wed, Mar 04, 2009 at 10:16:29PM +0100, Robert Millan wrote: >>>> else if (major == SCSI_DISK0_MAJOR) >>>> - sprintf (name, "/dev/sd%c", 'a' + minor / 16); >>>> + grub_util_getdiskname_scsi (name, 0, minor / 16); >>>> + else if (major == SCSI_DISK1_MAJOR) >>>> + grub_util_getdiskname_scsi (name, 1, minor / 16); >>>> [...] >>> Can this be factorized somehow? Space in raid.mod is quite critical; when >>> used it usually ends up in core.img, which needs to fit in the embed area. >> >> Oh, I'm sorry. I thought you were editting disk/raid.c. util/raid.c has no >> size issues. A macro would still be nice though. >> > What about making an array of SCSI_DISK?_MAJOR and then just go through it? Sounds good. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."