From: Ingo Molnar Date: Tue, 14 Apr 2009 08:34:53 +0000 Subject: Re: PATCH 1/3] blktrace: support per-partition tracing Message-Id: <20090414083453.GE27003@elte.hu> List-Id: References: <49E42620.4050701@cn.fujitsu.com> <20090414075947.GA27003@elte.hu> <49E445CB.4030001@cn.fujitsu.com> In-Reply-To: <49E445CB.4030001@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Li Zefan Cc: Jens Axboe , Arnaldo Carvalho de Melo , Theodore Ts'o , Shawn Du , LKML , linux-btrace@vger.kernel.org * Li Zefan wrote: > >> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...); > >> extern void blk_add_driver_data(struct request_queue *q, struct request *rq, > >> void *data, size_t len); > >> extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev, > >> + struct block_device *bdev, > >> char __user *arg); > >> extern int blk_trace_startstop(struct request_queue *q, int start); > >> extern int blk_trace_remove(struct request_queue *q); > > > > Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case > > here, the wrapper macros there need to be updated. > > > > Ah, sorry.. > > > (no need to resend - i fixed this up in the 1/3 and 3/3 patches) > > > > and thanks! (But I think only 1/3 patch needs to be fixed) 3/3 had context dependencies - no functionality dependency. > The 3rd patch can be for 2.6.30, if Ted or somene else wants to > use ftrace-plugin blktrace to trace dm devices in 2.6.30. ok, good point - we can cherry-pick it over into tracing/urgent after Ted reports back his experiences with these changes. Ingo