Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ltk0I-00036v-1S for mharc-grub-devel@gnu.org; Tue, 14 Apr 2009 10:52:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ltk0H-00036q-0Q for grub-devel@gnu.org; Tue, 14 Apr 2009 10:52:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ltk0G-00036e-Iu for grub-devel@gnu.org; Tue, 14 Apr 2009 10:52:48 -0400 Received: from [199.232.76.173] (port=41289 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ltk0G-00036b-Fc for grub-devel@gnu.org; Tue, 14 Apr 2009 10:52:48 -0400 Received: from mail.nexedi.com ([91.121.25.85]:59485 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ltk0G-0002IW-16 for grub-devel@gnu.org; Tue, 14 Apr 2009 10:52:48 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 9F3523D9F7 for ; Tue, 14 Apr 2009 16:52:45 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Tue, 14 Apr 2009 23:52:53 +0900 User-Agent: KMail/1.9.10 References: <200904111909.48927.okuji@enbug.org> <20090412.180707.168779439.davem@davemloft.net> <1239598981.4166.8.camel@ct> In-Reply-To: <1239598981.4166.8.camel@ct> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904142352.54107.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Build system improvement X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 14:52:49 -0000 On Monday 13 April 2009 14:03:01 Pavel Roskin wrote: > On Sun, 2009-04-12 at 18:07 -0700, David Miller wrote: > > From: Pavel Roskin > > Date: Sun, 12 Apr 2009 17:24:49 -0400 > > > > > On Sat, 2009-04-11 at 08:29 -0700, Colin D Bennett wrote: > > >> If we could build with -Werror, then it wouldn't be so hard to find > > >> the warnings since the build would abort... > > > > > > It's also possible to redirect stderr to a file so that the build > > > doesn't stumble on the first warning. > > > > I'm iffy about this. > > I meant that "warning hunters" can use it and have a choice what > warnings to fix. I didn't suggest stderr redirection to be part of the > build system. > > > There are some hard warnings to get rid of. > > > > For example when building certain grub-* tools there is no way > > to get around the current redefinitions we get of LONG_MAX and > > friends. (one comes in via grub headers, then the stdio.h include > > gets us the system definition, we can't use ifdef guards because > > the grub headers come in and define things first) > > I would explore the possibility of introducing GRUB_LONG_MAX. GRUB > already duplicates a lot of libc definitions. Yes. It is bad and dangerous to use the same symbols as libc. I think I have written this in the wiki: http://grub.enbug.org/CodingStyle Regards, Okuji