From: Qing He Subject: Re: [PATCH] ioemu: fix INTx disable bit in MSI-INTx translation Date: Thu, 16 Apr 2009 17:01:23 +0800 Message-ID: <20090416090123.GA26535@ub-qhe2> References: <1239802852-8480-1-git-send-email-qing.he@intel.com> <20090416173137.701B.27C06F64@necst.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090416173137.701B.27C06F64@necst.nec.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yuji Shimada Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, 2009-04-16 at 16:44 +0800, Yuji Shimada wrote: > On Wed, 15 Apr 2009 21:40:52 +0800 > Qing He wrote: > > > Fix the bug introduced in commit 8c771eb6: when msi-intx > > translation is enabled, int disable bit in PCI_COMMAND is set. > > This approach has two issues: > > 1. for some (buggy) devices, set INTx bit will also disable > > MSI so that MSI doesn't work any more. > > 2. it's never re-enabled when msi translation is turned off. > > If the guest uses INTx, it can't receive any interrupts > > from then. > > > > This patch leaves INTx disable bit unset if MSI-INTx translation > > is used. > > I have sent the patch to fix the issue that you pointed out. > > The following patch is. > http://lists.xensource.com/archives/html/xen-devel/2009-04/msg00300.html > > The patch has already applied in commit 290b6d18585c887ff2cfa30b239aa2fecfcd0308. Seems I didn't notice that. I'll have a look. Thanks, Qing > > Your changeset seem to be old. > Could you test the latest qemu-xen? > > Thanks, > -- > Yuji Shimada >