From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 17 Apr 2009 07:41:19 +0200 Subject: [U-Boot] [PATCH u-boot git] DaVinci Ethernet cleanup In-Reply-To: <200904121549.26602.david-b@pacbell.net> References: <200904121549.26602.david-b@pacbell.net> Message-ID: <20090417054119.GK31923@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15:49 Sun 12 Apr , David Brownell wrote: > From: David Brownell > > Chips without the EMAC controller won't need the utilities > it uses to read an Ethernet address from EEPROM; so don't > include them needlessly. > > Use is_valid_ether() to validate the address from EEPROM. > All-zero addresses aren't the only invalid addresses. > A fully erased EEPROM returns all-ones, also invalid... > > Switch those Ethernet utilities to use "%pM" for printing > MAC addresses; and not say ROM when they mean EEPROM. > > Signed-off-by: David Brownell Looks fine Ben any comments? Best Regards, J.