From: Jiri Denemark Subject: Re: [PATCH] Fix xenconsole after aborted save Date: Mon, 20 Apr 2009 17:58:14 +0200 Message-ID: <20090420155814.GC18963@orkuz.home> References: <20090420140436.GB18963@orkuz.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" , Gerd Hoffmann List-Id: xen-devel@lists.xenproject.org > > It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in > > case the event channel is unbound. The close() + open() combination was there > > before... I haven't touched that code except for skipping it when only rebind > > is required. > > And actually that is a bug, since you will leak the old dom->local_port. Ah, ok, thanks for fixing that... > I checked in an alternative patch as c/s 19561, so please take a look and > test that resolves your issue. Yes, the alternative patch works fine. > Another thing to note is I think this problem can only occur if the domU > does not support suspend cancellation Sure, the problem only occurs for kernels without SUSPEND_CANCEL feature. Jirka