From: Christoph Egger Subject: Re: [PATCH] Fix search pathes in python code Date: Wed, 22 Apr 2009 10:18:09 +0200 Message-ID: <200904221018.09538.Christoph.Egger@amd.com> References: <200904211718.59770.Christoph.Egger@amd.com> <18925.60913.289411.98000@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18925.60913.289411.98000@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tuesday 21 April 2009 18:01:53 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] Fix search pathes in python code"): > > Attached patch gets rid of hardcoded search pathes in python code. > > This is an interesting and useful thing to do in principle. What it > actually does is have the build system write the installation paths > into the python code. I think this is much more correct than the > existing arrangements. > > I haven't however tested this specific change :-). What platforms did > you test it on, NetBSD and Linux. > and with what build process ? in xen toplevel source directory run gmake dist-tools or PREFIX="/usr/local" gmake dist-tools Then have a look into dist/install, copy the files to your test machine machine, set LD_LIBRARY_PATH and PYTHONPATH and see if things work - i.e. if "xm console " finds the xenconsole binary. Once we use rpath, then setting LD_LIBRARY_PATH won't be necessary anymore. Christoph P.S.: I'm really wondering why Linux distributors don't send such patches. I think, they modify the xen build system to fit into their rpm's. -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632