From: Christoph Hellwig Subject: Re: [PATCH 2/3] ext4: Fix and simplify s_dirt handling Date: Fri, 1 May 2009 03:02:55 -0400 Message-ID: <20090501070255.GA2107@infradead.org> References: <1241152637-11986-1-git-send-email-tytso@mit.edu> <1241152637-11986-2-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ext4 Developers List To: Theodore Ts'o Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:43537 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbZEAHCz (ORCPT ); Fri, 1 May 2009 03:02:55 -0400 Content-Disposition: inline In-Reply-To: <1241152637-11986-2-git-send-email-tytso@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, May 01, 2009 at 12:37:16AM -0400, Theodore Ts'o wrote: > The s_dirt flag wasn't completely handled correctly, but it didn't > really matter when journalling was enabled. It turns out that when > ext4 runs without a journal, we don't clear s_dirt in places where we > should have, with the result that the high-level write_super() > function was writing the superblock when it wasn't necessary. > > So we fix this by making ext4_commit_super() clear the s_dirt flag, > and removing many of the other places where s_dirt is manipulated. > When journalling is enabled, the s_dirt flag might be left set more > often, but s_dirt really doesn't matter when journalling is enabled. Btw, you might want to move all s_dirt setting into a wrapper, so that it never gets set for journal mode. That way we can avoid superflous calls into the filesystem in that default mode.