From: Al Viro Date: Sun, 3 May 2009 12:16:04 +0100 Subject: [Ocfs2-devel] [PATCH 3/3] fs: Add the reflink(2) system call. In-Reply-To: <20090503074849.GA20399@infradead.org> References: <1241331303-23753-1-git-send-email-joel.becker@oracle.com> <1241331303-23753-4-git-send-email-joel.becker@oracle.com> <20090503062756.GO8822@parisc-linux.org> <20090503063902.GR8633@ZenIV.linux.org.uk> <20090503074849.GA20399@infradead.org> Message-ID: <20090503111604.GW8633@ZenIV.linux.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Matthew Wilcox , Joel Becker , linux-fsdevel@vger.kernel.org, jmorris@namei.org, ocfs2-devel@oss.oracle.com On Sun, May 03, 2009 at 03:48:49AM -0400, Christoph Hellwig wrote: > On Sun, May 03, 2009 at 07:39:02AM +0100, Al Viro wrote: > > Another question: do we want that to work across mounpoint boundary? > > It's probably OK in this case, but... > > I don't think so. Allowing any link-like semantics over mount point > boundaries will just cause problems. Quite. I realize that this is how vfs_link() is written, but I really wonder if we should turn that if (foo->i_sb != bar->i_sb) into BUG_ON() in both. Their callers have vfsmounts and ought to do the vfsmount-level check anyway, so running into *that* -EXDEV should be impossible.