From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 3 May 2009 20:05:19 +0200 Subject: [U-Boot] [RFC PATCH] console/device: rework function naming In-Reply-To: <59b21cf20905031054g42abe970s235cf7103f3af0a7@mail.gmail.com> References: <1241371349-2140-1-git-send-email-plagnioj@jcrosoft.com> <59b21cf20905031054g42abe970s235cf7103f3af0a7@mail.gmail.com> Message-ID: <20090503180519.GX25959@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 19:54 Sun 03 May , Magnus Lilja wrote: > Hi Jean-Christophe, > > diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c > > index 061da64..2b6b137 100644 > > --- a/drivers/mtd/ubi/vmt.c > > +++ b/drivers/mtd/ubi/vmt.c > > @@ -337,7 +337,7 @@ int ubi_create_volume(struct ubi_device *ubi, struct ubi_mkvol_req *req) > > ? ? ? ?vol->dev.class = ubi_class; > > > > ? ? ? ?sprintf(&vol->dev.bus_id[0], "%s_%d", ubi->ubi_name, vol->vol_id); > > - ? ? ? err = device_register(&vol->dev); > > + ? ? ? err = console_register(&vol->dev); > > ? ? ? ?if (err) { > > ? ? ? ? ? ? ? ?ubi_err("cannot register device"); > > ? ? ? ? ? ? ? ?goto out_gluebi; > > @@ -646,7 +646,7 @@ int ubi_add_volume(struct ubi_device *ubi, struct ubi_volume *vol) > > ? ? ? ?vol->dev.devt = dev; > > ? ? ? ?vol->dev.class = ubi_class; > > ? ? ? ?sprintf(&vol->dev.bus_id[0], "%s_%d", ubi->ubi_name, vol->vol_id); > > - ? ? ? err = device_register(&vol->dev); > > + ? ? ? err = console_register(&vol->dev); > > Again a bit surprised to find anything about consoles in the UBI code. > In contrast to my earlier comment, this code seems to be compiled > (i.e. it's not within #ifdef UBI_LINUX). > I'm guessing you did a global search/replace for > device_register=>console_register? yes I've use script to generate the patch for the RFC For ubi the device_register is replace via macro by 0 this will not been touch by the final patch and fully check before btw this is one of the confusing point of the current implementation Best Regards, J.