From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 3 May 2009 23:31:43 +0200 Subject: [U-Boot] [RFC PATCH] console/device: rework function naming In-Reply-To: <20090503200545.89C7583420E8@gemini.denx.de> References: <1241371349-2140-1-git-send-email-plagnioj@jcrosoft.com> <20090503184110.30C0683420E8@gemini.denx.de> <20090503184226.GY25959@game.jcrosoft.org> <20090503200545.89C7583420E8@gemini.denx.de> Message-ID: <20090503213143.GZ25959@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 22:05 Sun 03 May , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090503184226.GY25959@game.jcrosoft.org> you wrote: > > > > > > we now switch to console_XX and console_device_t > -----------------------^^^^^^^^^^ > > > > > Actually there is even a direct name conflict - console_init() is > > > already in use (in board/netphone/phone_console.c), and your patch > > > fails to resolve this conflict. > > it does, it's call consoles_init() > > Then your comment (see above) and the code disagree. > > > > Maybe "stdio" would be a better choice than "console" here? > > why not > > Hm... actually checking the code tells that stdio is already taken, > too - see show_stdio_dev(), stdio_devices[], stdio_names[]. btw we could stop to export the table for show_stdio_dev it's just a copy of the common/console.c ligne 604 so we can merge it > > But at least thesere are only few identifiers, so this could be delt > with. so no problem Best Regards, J.