From: Ben Dooks Subject: Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL Date: Sun, 3 May 2009 23:23:52 +0100 Message-ID: <20090503222352.GB5750@fluff.org.uk> References: <49EDC0BE.7040505@elphinstone.net> <20090422215646.GA19997@trinity.fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kumar Gala Cc: Ben Dooks , Linuxppc-dev Development , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Ware List-Id: linux-i2c@vger.kernel.org On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: > > On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: > >> On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: >>> >>> On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: >>> >>>> Recent DMA changes result in a BUG() when NULL is passed to >>>> dma_alloc_coherent in place of a device. >>>> >>>> Signed-off-by: Mark Ware >>>> --- >>>> >>>> This patch fixes the BUG() during boot that has appeared during the >>>> 2.6.30 window. It has been tested and appears correct on my 8280 >>>> based >>>> board. >>>> Sent to both linuxppc-dev and linux-i2c, since I'm not sure where it >>>> belongs. >>>> >>>> >>>> drivers/i2c/busses/i2c-cpm.c | 14 ++++++++------ >>>> 1 files changed, 8 insertions(+), 6 deletions(-) >>> >>> Acked-by: Kumar Gala >>> >>> Ben, I'm expecting you to pick this up unless you tell me otherwise. >> >> Yes. > > This go in yet? I've had to do a manual apply due to some changes in the driver, so can someone please do a build of my git tree at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-for-2630-rc5 or tell me which arch and defconfig to build. -- Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'