Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M16wy-0004AO-DQ for mharc-grub-devel@gnu.org; Mon, 04 May 2009 18:47:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M16ww-00049v-Ud for grub-devel@gnu.org; Mon, 04 May 2009 18:47:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M16ww-00049d-Js for grub-devel@gnu.org; Mon, 04 May 2009 18:47:50 -0400 Received: from [199.232.76.173] (port=54237 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M16ww-00049Y-AS for grub-devel@gnu.org; Mon, 04 May 2009 18:47:50 -0400 Received: from 74-93-104-97-washington.hfc.comcastbusiness.net ([74.93.104.97]:47955 helo=sunset.davemloft.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M16wv-0006rs-Rm for grub-devel@gnu.org; Mon, 04 May 2009 18:47:50 -0400 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 4222435C00F for ; Mon, 4 May 2009 15:47:43 -0700 (PDT) Date: Mon, 04 May 2009 15:47:43 -0700 (PDT) Message-Id: <20090504.154743.74571658.davem@davemloft.net> To: grub-devel@gnu.org From: David Miller X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [PATCH]: Fix ieee1275 iterator regression. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2009 22:47:51 -0000 When I converted this code over to user dynamically allocated strings, I inserted a bug by passing the address of the string pointer instead of the pointer itself. Committed. 2009-05-04 David S. Miller * kern/ieee1275/openfw.c (grub_children_iterate): Fix string pointer args to grub_ieee1275_get_property(). diff --git a/kern/ieee1275/openfw.c b/kern/ieee1275/openfw.c index 7d65023..31296b1 100644 --- a/kern/ieee1275/openfw.c +++ b/kern/ieee1275/openfw.c @@ -78,7 +78,7 @@ grub_children_iterate (char *devpath, struct grub_ieee1275_devalias alias; grub_ssize_t actual; - if (grub_ieee1275_get_property (child, "device_type", &childtype, + if (grub_ieee1275_get_property (child, "device_type", childtype, sizeof childtype, &actual)) continue; @@ -86,7 +86,7 @@ grub_children_iterate (char *devpath, &actual)) continue; - if (grub_ieee1275_get_property (child, "name", &childname, + if (grub_ieee1275_get_property (child, "name", childname, sizeof childname, &actual)) continue;