From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 0/8] virtio: add guest MSI-X support Date: Mon, 4 May 2009 14:54:50 +0300 Message-ID: <20090504115450.GB30001@redhat.com> References: <20090427123136.GA1152@redhat.com> <200904271600.30599.borntraeger@de.ibm.com> <49F5CA08.6060003@redhat.com> <20090427153936.GA2276@redhat.com> <49F6A672.8050704@redhat.com> <20090428174152.GA7604@redhat.com> <49F7420C.5070505@redhat.com> <20090428180248.GB7604@redhat.com> <49FEB398.4020906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christian Borntraeger , Rusty Russell , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40884 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbZEDL5B (ORCPT ); Mon, 4 May 2009 07:57:01 -0400 Content-Disposition: inline In-Reply-To: <49FEB398.4020906@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 04, 2009 at 12:21:28PM +0300, Avi Kivity wrote: > Michael S. Tsirkin wrote: >>>> So what I see is transports providing something like: >>>> >>>> struct virtio_interrupt_mapping { >>>> int virtqueue; >>>> int interrupt; >>>> }; >>>> >>>> map_vqs_to_interrupt(dev, struct virtio_interrupt_mapping *, int nvirtqueues); >>>> unmap_vqs(dev); >>>> >>> Isn't that the same thing? Please explain the flow. >>> >> >> So to map vq 0 to vector 0, vq 1 to vector 1 and vq 2 to vector 2 the driver would do: >> >> struct virtio_interrupt_mapping mapping[3] = { {0, 0}, {1, 1}, {2, 2} }; >> vec = map_vqs_to_interrupt(dev, mapping, 3); >> if (vec) { >> error handling >> } >> >> and then find_vq as usual. >> > > Yes, that works. > > Given that pci_enable_msix() can fail, we can put the retry loop in > virtio-pci, and instead of a static mapping, supply a dynamic mapping: > > static void get_vq_interrupt(..., int nr_interrupts, int vq) > { > /* reserve interrupt 0 to config changes; round-robin vqs to > interrupts */ > return 1 + (vq % (nr_interrupts - 1)); > } > > driver_init() > { > map_vqs_to_interrupt(dev, get_vq_interrupt); > } > > map_vqs_to_interrupts() would call get_vq_interrupt() for each vq, > assuming the maximum nr_interrupts, and retry with smaller nr_interrupts > on failure. Since guest drivers are going to do round-robin most of the time, I think the right thing to do is to make the API simple, along the lines proposed by Rusty, and make the guest/host ABI rich enough to support arbitrary mapping, along the lines proposed by you. We can always change the API, ABI is harder. -- MST