From: Glauber Costa Subject: Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do. Date: Mon, 4 May 2009 11:26:27 -0300 Message-ID: <20090504142627.GG12844@poweredge.glommer> References: <1241037101-24842-1-git-send-email-glommer@redhat.com> <1241037101-24842-2-git-send-email-glommer@redhat.com> <49FEA7C2.7050908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, ehabkost@redhat.com To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50774 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbZEDOVm (ORCPT ); Mon, 4 May 2009 10:21:42 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n44ELZZa009277 for ; Mon, 4 May 2009 10:21:35 -0400 Content-Disposition: inline In-Reply-To: <49FEA7C2.7050908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 04, 2009 at 11:30:58AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> As soon as we call kvm_init_vcpu(), we start the vcpu thread. >> However, there is still things that has to be done, as soon >> as the new CPUState is created. Examples include initializing the >> apic, halting the cpu, etc. >> >> Without this patch, it is possible that the cpu may want to start >> using those things, before initializing them, leading to segfaults. >> We introduce another state variable, "initialized", meaning that >> the cpu is already created, but not totally initialized, >> to serialize it. >> >> Before this patch: >> (qemu) cpu_set X online => segfaults ~ 80 % of the time >> After this patch: >> (qemu) cpu_set X online => works. >> >> > > Is it possible to move all those things to the vcpu thread, so it > serializes naturally? Everything is possible. moving everything to inside cpu_x86_init would be best, IMHO. We have to remember qemu will have the same problem when kvm gets in there. However, we might as well remember that cpu_x86_init creates a x86 cpu. It does not have to be a pc cpu. So initializing apic and the like inside cpu_x86_init could break this separability. Of course, right now we don't do anything other than pc, so we might not care. But theorectically... > > I'd like to avoid vcpu ioctls from more than one thread, in case we ever > move to a syscall implementation. Although I don't see exactly what's your point in here. We're just adding a serialization points through pthreads function, not doing any ioctl from the outside.