Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1jKf-0008Bf-W5 for qemu-devel@nongnu.org; Wed, 06 May 2009 11:46:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1jKb-00089x-3J for qemu-devel@nongnu.org; Wed, 06 May 2009 11:46:53 -0400 Received: from [199.232.76.173] (port=51454 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1jKa-00089p-QO for qemu-devel@nongnu.org; Wed, 06 May 2009 11:46:48 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52502) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1jKa-0004Hf-Ay for qemu-devel@nongnu.org; Wed, 06 May 2009 11:46:48 -0400 Date: Wed, 6 May 2009 12:51:41 -0300 From: Glauber Costa Message-ID: <20090506155141.GE26401@poweredge.glommer> References: <1241621382-21577-1-git-send-email-glommer@redhat.com> <1241621382-21577-2-git-send-email-glommer@redhat.com> <1241621382-21577-3-git-send-email-glommer@redhat.com> <4A01AF78.7050102@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A01AF78.7050102@siemens.com> Subject: [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, May 06, 2009 at 05:40:40PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > We can safely do that inconditionally, so move to processor defined > > flags like any other flag. > > > > Signed-off-by: Glauber Costa > > --- > > hw/pc.c | 4 ---- > > target-i386/helper.c | 2 +- > > 2 files changed, 1 insertions(+), 5 deletions(-) > > > > diff --git a/hw/pc.c b/hw/pc.c > > index 351de83..b726c17 100644 > > --- a/hw/pc.c > > +++ b/hw/pc.c > > @@ -851,10 +851,6 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size, > > } > > if (i != 0) > > env->halted = 1; > > - if (smp_cpus > 1) { > > - /* XXX: enable it in all cases */ > > - env->cpuid_features |= CPUID_APIC; > > - } > > if (pci_enabled) { > > apic_init(env); > > } > > diff --git a/target-i386/helper.c b/target-i386/helper.c > > index 2210412..2c11cd3 100644 > > --- a/target-i386/helper.c > > +++ b/target-i386/helper.c > > @@ -102,7 +102,7 @@ typedef struct x86_def_t { > > char model_id[48]; > > } x86_def_t; > > > > -#define I486_FEATURES (CPUID_FP87 | CPUID_VME | CPUID_PSE) > > +#define I486_FEATURES (CPUID_FP87 | CPUID_VME | CPUID_PSE | CPUID_APIC) > > Without doing my homework: > What impact will it have on an emulated CPUs without [L]APIC? I'm > thinking of -M isapc e.g. I tried, and it still boots fine. The flag just indicates it supports an apic, not that it has one.