Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1jaS-0004zL-EC for qemu-devel@nongnu.org; Wed, 06 May 2009 12:03:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1jaN-0004xJ-E3 for qemu-devel@nongnu.org; Wed, 06 May 2009 12:03:11 -0400 Received: from [199.232.76.173] (port=34532 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1jaN-0004x4-8s for qemu-devel@nongnu.org; Wed, 06 May 2009 12:03:07 -0400 Received: from mx2.redhat.com ([66.187.237.31]:46287) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1jaM-0000AY-IO for qemu-devel@nongnu.org; Wed, 06 May 2009 12:03:06 -0400 Date: Wed, 6 May 2009 13:08:00 -0300 From: Glauber Costa Message-ID: <20090506160800.GF26401@poweredge.glommer> References: <1241621382-21577-1-git-send-email-glommer@redhat.com> <1241621382-21577-2-git-send-email-glommer@redhat.com> <1241621382-21577-3-git-send-email-glommer@redhat.com> <1241621382-21577-4-git-send-email-glommer@redhat.com> <1241621382-21577-5-git-send-email-glommer@redhat.com> <4A01B224.8080608@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A01B224.8080608@siemens.com> Subject: [Qemu-devel] Re: [PATCH 4/4] move apic functions to a separate apic.h header List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, May 06, 2009 at 05:52:04PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > Later on, we'll want to call an apic function from helper.c. > > The inclusion of pc.h, besides totally ugly, leads to a lot of > > clashes. > > > > Signed-off-by: Glauber Costa > > --- > > hw/apic.c | 1 + > > hw/apic.h | 19 +++++++++++++++++++ > > hw/ioapic.c | 1 + > > hw/mc146818rtc.c | 1 + > > hw/pc.c | 1 + > > hw/pc.h | 15 --------------- > > 6 files changed, 23 insertions(+), 15 deletions(-) > > create mode 100644 hw/apic.h > > > > diff --git a/hw/apic.c b/hw/apic.c > > index d63d74b..72dbe88 100644 > > --- a/hw/apic.c > > +++ b/hw/apic.c > > @@ -19,6 +19,7 @@ > > */ > > #include "hw.h" > > #include "pc.h" > > +#include "apic.h" > > Does it still need pc.h then? yes. For things like RTCState. > > > #include "qemu-timer.h" > > #include "host-utils.h" > > > > diff --git a/hw/apic.h b/hw/apic.h > > new file mode 100644 > > index 0000000..2437e9f > > --- /dev/null > > +++ b/hw/apic.h > > @@ -0,0 +1,19 @@ > > +#ifndef _APIC_H_ > > +#define _APIC_H_ > > "APIC_H", otherwise fine. ok.