From: Mike Frysinger Date: Wed, 6 May 2009 19:28:07 -0400 Subject: [U-Boot] [PATCH v2] mtd: nand: new base driver for memory mapped nand devices In-Reply-To: <20090506205118.9E12F83420E8@gemini.denx.de> References: <1239499602-19356-1-git-send-email-vapier@gentoo.org> <1241615121-15945-1-git-send-email-vapier@gentoo.org> <20090506205118.9E12F83420E8@gemini.denx.de> Message-ID: <200905061928.08762.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 06 May 2009 16:51:18 Wolfgang Denk wrote: > In Mike Frysinger wrote: > > --- /dev/null > > +++ b/drivers/mtd/nand/nand_plat.c > > @@ -0,0 +1,53 @@ > > +/* > > + * Genericish driver for memory mapped NAND devices > > Genericish ? i tried to make it generic. i dont know if i accomplished that :). > > +#define NAND_PLAT_WRITE_CMD(cmd, chip) > > BFIN_NAND_WRITE(BFIN_NAND_CLE(chip), cmd) +#define > > NAND_PLAT_WRITE_ADR(cmd, chip) BFIN_NAND_WRITE(BFIN_NAND_ALE(chip), cmd) > > +#define NAND_PLAT_DEV_READY(chip) ((*pPORTFIO & BFIN_NAND_READY) ? > > 1 : 0) +#define NAND_PLAT_INIT() \ > > + do { \ > > + *pPORTF_FER &= ~BFIN_NAND_READY; \ > > + *pPORTFIO_DIR &= ~BFIN_NAND_READY; \ > > + *pPORTFIO_INEN |= BFIN_NAND_READY; \ > > + } while (0) > > Please use I/O accessors instead of pointers. OK -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090506/af9bcacd/attachment.pgp