Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1onv-0006fp-S0 for qemu-devel@nongnu.org; Wed, 06 May 2009 17:37:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1onq-0006fE-QZ for qemu-devel@nongnu.org; Wed, 06 May 2009 17:37:27 -0400 Received: from [199.232.76.173] (port=55825 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1onq-0006fB-JM for qemu-devel@nongnu.org; Wed, 06 May 2009 17:37:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59076) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1onq-0004uM-4l for qemu-devel@nongnu.org; Wed, 06 May 2009 17:37:22 -0400 Date: Wed, 6 May 2009 18:42:14 -0300 From: Glauber Costa Subject: Re: [Qemu-devel] [PATCH 3/4] move halted state setting to inside of cpu_x86_init Message-ID: <20090506214214.GH26401@poweredge.glommer> References: <1241621382-21577-1-git-send-email-glommer@redhat.com> <1241621382-21577-2-git-send-email-glommer@redhat.com> <1241621382-21577-3-git-send-email-glommer@redhat.com> <1241621382-21577-4-git-send-email-glommer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, May 06, 2009 at 10:31:15PM +0300, Blue Swirl wrote: > On 5/6/09, Glauber Costa wrote: > > cpus other than the first one starting at the halted state > > is a safe assumption to anyone. Move it to where it belongs. > > The code should be conditional to !CONFIG_USER_ONLY. Fine. > > The same happens with Sparc, so I'd move this to exec.c:cpu_exec_init(). It would be indeed, better. Anyone from other arches opposes to this?