From: David Miller Subject: Re: [PATCH]ipv6:use ipv6_addr_type instead of __ipv6_addr_type Date: Fri, 08 May 2009 00:48:35 -0700 (PDT) Message-ID: <20090508.004835.216058418.davem@davemloft.net> References: <20090507.145931.179746218.davem@davemloft.net> <4A038853.4020205@cn.fujitsu.com> <20090508.004420.22402966.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org To: yanghy@cn.fujitsu.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:52076 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302AbZEHHsj (ORCPT ); Fri, 8 May 2009 03:48:39 -0400 In-Reply-To: <20090508.004420.22402966.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Fri, 08 May 2009 00:44:20 -0700 (PDT) > From: Yang Hongyang > Date: Fri, 08 May 2009 09:18:11 +0800 > >> David Miller wrote: >>> From: Yang Hongyang >>> Date: Thu, 07 May 2009 15:47:38 +0800 >>> >>>> Although the function of these two functions are the same,we should use the >>>> encapsulation function of __ipv6_addr_type >>>> >>>> Signed-off-by: Yang Hongyang >>> >>> Are you sure? ipv6_addr_type() masks out the upper 16-bits >>> of __ipv6_addr_type()'s return value, which is the scope. >>> >>> I'm not convinced that is what we want to do here. >> >> My advice here is that the function which has __ maybe shouldn't be directly used. I also want to address this statement on it's own, it's simply not true. "__" means "think carefully before using this function", or "this function requires a special environment for proper usage" It DOES NOT mean "do not use directly." It's never meant this. So ever basis for your patch is fundamentally flawed.