From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/5] mm: Add __GFP_NO_OOM_KILL flag Date: Fri, 8 May 2009 15:42:47 +0200 Message-ID: <200905081542.48942.rjw@sisk.pl> References: <200905080111.31273.rjw@sisk.pl> <20090508101651.aa4d513d.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090508101651.aa4d513d.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Content-Disposition: inline Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: KAMEZAWA Hiroyuki Cc: David Rientjes , Andrew Morton , fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Friday 08 May 2009, KAMEZAWA Hiroyuki wrote: > On Fri, 8 May 2009 01:11:30 +0200 > "Rafael J. Wysocki" wrote: > > > + for_each_populated_zone(zone) > > + zone_set_flag(zone, ZONE_OOM_LOCKED); > > > + for_each_populated_zone(zone) > > + zone_clear_flag(zone, ZONE_OOM_LOCKED); > > + > > Isn't it better to make above 2 be functions and move to mm/oom_kill.c ? Hmm, OK. I'll do it. Well, in fact snapshot.c is all about memory management, so perhaps it's a good idea to move it into mm as a whole. ;-) Best, Rafael