Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M565F-0005Ct-7v for qemu-devel@nongnu.org; Fri, 15 May 2009 18:40:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5659-0005B2-9e for qemu-devel@nongnu.org; Fri, 15 May 2009 18:40:52 -0400 Received: from [199.232.76.173] (port=37719 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5659-0005Aw-5L for qemu-devel@nongnu.org; Fri, 15 May 2009 18:40:47 -0400 Received: from 15.mail-out.ovh.net ([91.121.27.217]:35372) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1M5658-0006h1-JP for qemu-devel@nongnu.org; Fri, 15 May 2009 18:40:46 -0400 Date: Sat, 16 May 2009 00:33:12 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [Qemu-devel] [PATCH 02/15] S3C system on chip integrated peripheral device state header Message-ID: <20090515223312.GM16288@game.jcrosoft.org> References: <1241599494-28654-1-git-send-email-vince@simtec.co.uk> <1241599494-28654-3-git-send-email-vince@simtec.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241599494-28654-3-git-send-email-vince@simtec.co.uk> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Sanders Cc: qemu-devel@nongnu.org > + uint32_t tclk1; /* second timer clock source frequency */ > + > + /* GPIO block */ > + uint32_t gpio_reg[47]; > + > + /* Realtime clock */ > + uint8_t rtc_reg[19]; > + > + /* i2c */ > + struct s3c24xx_i2c_state_s *iic; > + > + /* Timers, (Specifically timer4) */ > + uint32_t timers_reg[17]; it will be better to define a struct with the timers_reg content same with the other arry > + QEMUTimer *timer4; > + uint32_t timer4_reload_value; > + int64_t timer4_last_ticked; > + > + /* LCD controller */ > + struct s3c24xx_lcd_state_s *lcd; > + > + /* NAND controller, and chip attached */ > + uint32_t nand_reg[5]; > + struct nand_flash_s *nand_chip; > +} S3CState; Best Regards, J.