From: Jean-Christophe PLAGNIOL-VILLARD Date: Sat, 16 May 2009 12:25:28 +0200 Subject: [U-Boot] [PATCH 5/6] ZOOM2 Add serial support. In-Reply-To: <4A0DDBAD.5020703@windriver.com> References: <1241731686-9844-1-git-send-email-Tom.Rix@windriver.com> <1241731686-9844-2-git-send-email-Tom.Rix@windriver.com> <1241731686-9844-3-git-send-email-Tom.Rix@windriver.com> <1241731686-9844-4-git-send-email-Tom.Rix@windriver.com> <1241731686-9844-5-git-send-email-Tom.Rix@windriver.com> <20090508193643.GB28925@game.jcrosoft.org> <4A0DDBAD.5020703@windriver.com> Message-ID: <20090516102528.GO16288@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:16 Fri 15 May , Tom wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 16:28 Thu 07 May , Tom Rix wrote: >> >>> Zoom2 serial is in general supplied by one of the 4 UARTS on the debug board. >>> The default serial is from the USB connector on left side of the debug board. >>> >>> +/* >>> + * This the the zoom2, board specific, gpmc configuration for the >>> + * quad uart on the debug board. The more general gpmc configurations >>> + * are setup at the cpu level in cpu/arm_cortexa8/omap3/mem.c >>> + */ >>> +extern void enable_gpmc_config(u32 *gpmc_config, gpmc_csx_t *gpmc_cs_base, >>> + u32 base, u32 size); >>> + >>> +static u32 gpmc_serial_TL16CP754C[GPMC_MAX_REG] = { >>> + 0x00011000, >>> + 0x001F1F01, >>> + 0x00080803, >>> + 0x1D091D09, >>> + 0x041D1F1F, >>> + 0x1D0904C4, 0 >>> +}; >>> >> Any chance to have comment at least about these value? >> > > I have not gotten a response for a better comment. > > Can I have a pass on this ? ok but add a comment in the code and the commit to explain why you can not provide comment about these values Best Regards, J.