From: Marcelo Tosatti Subject: Re: [PATCH 3/4] Nested SVM: Implement INVLPGA v2 Date: Tue, 19 May 2009 10:58:15 -0300 Message-ID: <20090519135815.GB4397@amt.cnet> References: <1242730443-15656-1-git-send-email-agraf@suse.de> <1242730443-15656-2-git-send-email-agraf@suse.de> <1242730443-15656-3-git-send-email-agraf@suse.de> <1242730443-15656-4-git-send-email-agraf@suse.de> <4A12AD0C.9030402@redhat.com> <20090519135416.GA4397@amt.cnet> <4A12BAA0.5010401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Graf , kvm@vger.kernel.org, joerg.roedel@amd.com To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36476 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbZESN6q (ORCPT ); Tue, 19 May 2009 09:58:46 -0400 Content-Disposition: inline In-Reply-To: <4A12BAA0.5010401@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 19, 2009 at 04:56:48PM +0300, Avi Kivity wrote: > Marcelo Tosatti wrote: >>> I think that for ASID!=0 you can actually do nothing. The guest >>> entry is a cr3 switch, so we'll both get a tlb flush and a resync on >>> any modified ptes. >>> >>> For ASID==0 you can do the invlpg thing. >>> >>> Marcelo? >>> >> >> kvm_mmu_invlpg is cheap, better just invalidate the entry. If hyper-v >> uses invlpga to invalidate TLB entries which it has updated pte's in >> memory for, and you skip the invalidation now and somehow later use an >> unsync spte, you're toast. >> > > But won't the guest entry cause a resync? If its a cr3/cr4 exit, yes. > Doing nothing is even cheaper. My brain is nested.