From: Chris Wright Subject: Re: [PATCH] kvm-kmod: fix kvm_request_irq race Date: Wed, 20 May 2009 23:38:16 -0700 Message-ID: <20090521063816.GT20823@sequoia.sous-sol.org> References: <20090521062135.GR20823@sequoia.sous-sol.org> <4A14F4AD.9060408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Wright , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from sous-sol.org ([216.99.217.87]:38153 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751303AbZEUGi3 (ORCPT ); Thu, 21 May 2009 02:38:29 -0400 Content-Disposition: inline In-Reply-To: <4A14F4AD.9060408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Avi Kivity (avi@redhat.com) wrote: > Since this mutex is in a header file, it can be instantiated multiple > times. It will only serialize callers within a translation unit. > Please define it in a C file. > > Would be best to move the the code as well. Yeah it seems to get linked multiple times (when I tried that I found duplicates). I'll look again. thanks, -chris