From: Wolfgang Denk Date: Sun, 24 May 2009 22:13:27 +0200 Subject: [U-Boot] [PATCH 1/2] 83xx: Replace CONFIG_MPC83XX with CONFIG_MPC83xx In-Reply-To: <1243192952.703.7.camel@ptyser-laptop> References: <82eccabef9b5f2ad7f747ee9ba966546ef366745.1243030613.git.ptyser@xes-inc.com> <20090524140034.568bca6d.kim.phillips@freescale.com> <1243192952.703.7.camel@ptyser-laptop> Message-ID: <20090524201327.CB44C832E416@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Peter, In message <1243192952.703.7.camel@ptyser-laptop> you wrote: > > > CodingStyle Ch.12 suggests that it's the other fsl arches that are in > > violation here, not 83XX: Agreed... > Either way is fine with me, as long as things are consistent. It looked > like most Freescale CPUs in U-Boot as well as Linux used the lowercase > convention for CONFIG_ so I thought: > a. Most likely someone made a conscious decision to use lowercase > b. It'd be much easier to change just 83xx than all other arches:) > > If others would prefer standardizing on uppercase, I can submit new > patches for 85xx, 5xxx, 86xx, etc. This would be still be inconsistent > with Linux though, which is a bit annoying. It seems Linux uses 8?xx with very few exceptions (CONFIG_SND_VIA82XX* and CONFIG_EDAC_MPC85XX), so let's do the same here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It's certainly convenient the way the crime (or condition) of stupidity carries with it its own punishment, automatically admisistered without remorse, pity, or prejudice. :-) -- Tom Christiansen in <559seq$ag1$1@csnews.cs.colorado.edu>