From: Marcelo Tosatti Subject: Re: [PATCH 1/2] KVM: Make paravirt tlb flush also reload PAE PDPTEs Date: Mon, 25 May 2009 08:59:33 -0300 Message-ID: <20090525115933.GB3417@amt.cnet> References: <1243241244-25953-1-git-send-email-avi@redhat.com> <1243241244-25953-2-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53618 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbZEYPDS (ORCPT ); Mon, 25 May 2009 11:03:18 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4PF3KMR004317 for ; Mon, 25 May 2009 11:03:20 -0400 Content-Disposition: inline In-Reply-To: <1243241244-25953-2-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 25, 2009 at 11:47:23AM +0300, Avi Kivity wrote: > The paravirt tlb flush may be used not only to flush TLBs, but also > to reload the four page-directory-pointer-table entries, as it is used > as a replacement for reloading CR3. Change the code to do the entire > CR3 reloading dance instead of simply flushing the TLB. Ugh, my bad. ACK. > > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/mmu.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 6880a4c..7030b5f 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -2927,8 +2927,7 @@ static int kvm_pv_mmu_write(struct kvm_vcpu *vcpu, > > static int kvm_pv_mmu_flush_tlb(struct kvm_vcpu *vcpu) > { > - kvm_x86_ops->tlb_flush(vcpu); > - set_bit(KVM_REQ_MMU_SYNC, &vcpu->requests); > + kvm_set_cr3(vcpu, vcpu->arch.cr3); > return 1; > } > > -- > 1.6.0.6